Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook resource exposes secrets on preview #371

Closed
IaroslavTitov opened this issue Aug 6, 2024 · 1 comment
Closed

Webhook resource exposes secrets on preview #371

IaroslavTitov opened this issue Aug 6, 2024 · 1 comment
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@IaroslavTitov
Copy link
Contributor

What happened?

Whenever a secret is passed into Webhook's secret property, it is not covered up with [secret during] preview.

Example

Create a webhook resource, with secret passed into secret field.
Run pulumi up, then select details.
Value is exposed.

Output of pulumi about

Not relevant

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@IaroslavTitov IaroslavTitov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 6, 2024
@cleverguy25 cleverguy25 added this to the 0.109 milestone Aug 6, 2024
@IaroslavTitov IaroslavTitov added resolution/fixed This issue was fixed and removed needs-triage Needs attention from the triage team labels Aug 6, 2024
@IaroslavTitov
Copy link
Contributor Author

Fixed in #370

@IaroslavTitov IaroslavTitov self-assigned this Aug 6, 2024
@IaroslavTitov IaroslavTitov modified the milestones: 0.109, 0.108 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

2 participants