Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider aligning asset handling to the pulumi-terraform-bridge #394

Open
komalali opened this issue Aug 26, 2024 · 0 comments
Open

Consider aligning asset handling to the pulumi-terraform-bridge #394

komalali opened this issue Aug 26, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@komalali
Copy link
Member

We added handling for the Environment.Yaml property, which is of an asset type, to expand the asset during Check into its string form. In the future, we should consider aligning our asset handling with how the bridge handles it, since it offers more flexibility for path-based properties.

From @pgavlin: I think that this will likely work in the case that the underlying resource expects a literal. in the case the underlying resource expects a path, things get muddier. assets are a bit ill-considered, but part of what they're intended to address is the case of properties that accept paths, as paths may (will) differ from machine to machine,

The bridge walks the old inputs and records which property values were assets, then walks the new state and turns anything that was an asset back into an asset.

Links to source:

@komalali komalali added the kind/engineering Work that is not visible to an external user label Aug 26, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Aug 26, 2024
@komalali komalali removed the needs-triage Needs attention from the triage team label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants