Fix refresh on agent pools #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IaroslavTitov
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM, one quick question - was there no need to fix agentPoolId? The bug mentions that it's also missing after refresh and update
Also just now saw I also noticed the field description changes to "" after the refresh and back to null after the update.
Or will those be in separate PRs?
yeah I did specifically check for this and I couldn't repro the missing ID.
Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the AgentPool resource would lose the tokenValue property on refresh. Also enables an existing example for agent pools which would have highlighted the bug, but didn't because it wasn't running :/
Fixes #379