Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the yaml panic #421

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix the yaml panic #421

merged 1 commit into from
Oct 7, 2024

Conversation

komalali
Copy link
Member

@komalali komalali commented Oct 2, 2024

Fixes #418

@komalali komalali requested a review from a team October 2, 2024 02:36
seanyeh
seanyeh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@seanyeh seanyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want to make sure we test this with both computed/non-computed values but otherwise 👍

@seanyeh
Copy link
Contributor

seanyeh commented Oct 7, 2024

@komalali I tested this locally, confirmed fixes the panic and working with both computed/non-computed

@komalali komalali merged commit a396a31 into main Oct 7, 2024
13 checks passed
@komalali komalali deleted the komal/fix-yaml-panic branch October 7, 2024 20:02
@jkodroff jkodroff mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyeh seanyeh seanyeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in the latest version of the pulumi service has a bug with the Environment yaml field.
2 participants
@komalali @seanyeh