Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF SDKv2 does not support complex types under Map #1873

Open
t0yv0 opened this issue Apr 12, 2024 · 2 comments
Open

TF SDKv2 does not support complex types under Map #1873

t0yv0 opened this issue Apr 12, 2024 · 2 comments
Labels
kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented Apr 12, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Per hashicorp/terraform-plugin-sdk#62 the complex types under TypeMap are not supported. If we tighten the schema validators to enforce it can help with bridge hardening. It will also help avoid issues with providers that accidentally use this feature - much more appropriate to reject this a build-time (or at least warn).

Affected area/feature

@t0yv0 t0yv0 added needs-triage Needs attention from the triage team kind/enhancement Improvements or new features labels Apr 12, 2024
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Apr 15, 2024
@VenelinMartinov
Copy link
Contributor

Should we warn the author of the provider and match the TF behaviour?

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 15, 2024

That's the best probably.. I could be good to run a test to see how many instances of this are across our ecosystem. Rejecting it out of hand is least effort but the more "correct" thing to do would be what TF does and treat these as map of strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants