Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Cross-testing coverage for Create #2537

Open
5 tasks
iwahbe opened this issue Oct 30, 2024 · 1 comment
Open
5 tasks

[EPIC] Cross-testing coverage for Create #2537

iwahbe opened this issue Oct 30, 2024 · 1 comment
Labels
area/testing The internal testing setup of the bridge kind/epic Large new features or investments

Comments

@iwahbe
Copy link
Member

iwahbe commented Oct 30, 2024

We have made tremendous progress on testing in the bridge: cross-test, providertest and replay testing have made it much easier to write and maintain high quality tests of the bridge. cross-test has crucially allowed us to start comparing our behavior directly to Terraform. Now that we've written the testing libraries, we need to actually write tests.

We are starting with create because it is one of the simplist CRUD methods. It allows us to lock in correct behavior on sending values, defaults validators, etc before we move onto more complicated interactions like Diff/Update (Plan).

Many tests aren't really specific to Create, but are instead about converting values. These tests will be implemented against the crosstests.Create verb, but will effectively cover all verbs (since they use the same code path).

SDKv2

Each issue corresponds to a file1 in pkg/tfbridge/tests/. The expectation is that future (and current) maintainers should be able to check if a feature is under test by going searching for a test file in pkg/tfbridge/tests/ that applies to the area under test.

PF

Each issue corresponds to a file1 in pkg/pf/tfbridge2.

Cross-test improvements

Footnotes

  1. The file may already exist, or it may need to be created. 2

  2. The path is different for PF and SDKv2 because SDKv2 cross-tests transitively imports pkg/tfbridge.

@iwahbe iwahbe added area/testing The internal testing setup of the bridge kind/epic Large new features or investments labels Oct 30, 2024
@cleverguy25
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing The internal testing setup of the bridge kind/epic Large new features or investments
Projects
None yet
Development

No branches or pull requests

2 participants