Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Do not require aio_agent_version to be present #66

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Do not require aio_agent_version to be present #66

merged 1 commit into from
Nov 20, 2019

Conversation

fizmat
Copy link
Contributor

@fizmat fizmat commented Nov 16, 2019

This was started in PR #41 but one more check was left behind in device_manager::devices

I don't even think it's an enterprise/non-enterprise distinction. It looks like packaging differences:
When facter is built as part of the puppet-agent package, as it does in the puppetlabs yum repo, it gets the agent version fact compiled in from the config variable. Hence, I suspect, the aio (all-in-one) prefix.
If facter lives in a separate package, as it does in Arch official repos, it can't have the fact compiled in, as the agent version can change independently. At least this is the way I understand it.

As an Arch user, this is the second puppet module where I run into problems with missing aio_agent_version.

@fizmat fizmat requested a review from a team November 16, 2019 22:09
@DavidS
Copy link
Contributor

DavidS commented Nov 20, 2019

As an academic, it is my opinion that it's Arch's responsibility to provide a runtime environment suitable for existing content to work, if they diverge from the official packaging.

As an engineer, I agree that the check is overzealous.

Thanks for your contribution!

@DavidS DavidS changed the title (maint) Finish removing node check based on aio_agent_version Do not require aio_agent_version to be present Nov 20, 2019
@DavidS DavidS added the bugfix Something isn't working label Nov 20, 2019
@DavidS DavidS merged commit 57533eb into puppetlabs:master Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants