-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use streaming JSON parser (ijson) #42
Comments
Ah yeah, totally down for adding this, falling back to default behaviour if it fails |
have been thinking more about this with me adding more formats to browserexport, will probably create a meta-package like you have in exporthelpers that this will have as a dependency |
Another relevant thing that may be worth extracting from HPI is a library for accessing compressed stuff karlicoss/kompress#10 |
started extracting kompress stuff here btw https://github.com/karlicoss/kompress -- will add more docs and think if needs any refactoring and then will move HPI and bleanser to use it |
looks good I think the only thing it doesnt meet my usecase for is gzip has the same will PR that, would be nice to be able to use that in my tools instead of re-implementing it everywhere |
I guess not a super big deal since we use caching, but it does give significant (almost 2x speedups)
Had good success using it for a couple of DALs https://github.com/karlicoss/exporthelpers/blob/804b8afa070d8017ad15710a2a179e71ea60316f/dal_helper.py#L140-L171 (made it an optional dependency for backwards compatibility since
ijson
involves some binaries which might be unavailable for some platforms)related: #40
The text was updated successfully, but these errors were encountered: