Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOVE] set the etcd max transaction limit #196

Closed
purpleidea opened this issue Jun 13, 2017 · 5 comments
Closed

[LOVE] set the etcd max transaction limit #196

purpleidea opened this issue Jun 13, 2017 · 5 comments
Labels

Comments

@purpleidea
Copy link
Owner

This should be a beginner level patch for someone who is either new-ish to golang, or new to mgmt. It is meant to encourage new programmers to get involved with mgmt.

In etcd there are transactions which are composed of a number of operations. There was previously a constant limit to the number of ops per transaction to avoid blocking other clients. The default limit was too small for most users, so it's now a configurable setting.

For this patch, we should set this to a reasonable default. The upstream change is here: etcd-io/etcd#7976

The patch would likely need to add our own constant, and this would be in etcd/etcd.go where we have the embed code.

Happy hacking, and ping me for questions!

@nitinprakash96
Copy link

Hi, I'd like to work on this.!

@purpleidea
Copy link
Owner Author

@nitinprakash96 Great... Need any pointers to get started or have any questions? If so, please ping purpleidea in #mgmtconfig on Freenode.

@purpleidea
Copy link
Owner Author

This is where the embed server code is, which is where this would need to be hooked in:

https://github.com/purpleidea/mgmt/blob/master/etcd/etcd.go#L1650

@purpleidea
Copy link
Owner Author

NOTE: this has been fixed in #200 and is waiting on merge.

@purpleidea
Copy link
Owner Author

merged in 24cb2e6

Thanks again, and sorry for our misfire in thinking the patch would have worked earlier. Please let us know if we can help you get involved with any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants