Skip to content

Commit

Permalink
Fixed blue focus-within state for sl-menu-items (#3836)
Browse files Browse the repository at this point in the history
fixes #3806
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
Bugfix

## Describe the current behavior? + Describe the new behavior?
Described here
shoelace-style/shoelace#1185

## PR Checklist
- [x] Test: run `npm run test` and ensure that all tests pass
- [x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.

## Additional Information
Thanks to Cory from shoelace

Co-authored-by: Nikola Metulev <[email protected]>
  • Loading branch information
Jaylyn-Barbee and nmetulev committed Feb 15, 2023
1 parent e6ff6ef commit 495ac02
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 0 deletions.
5 changes: 5 additions & 0 deletions apps/pwabuilder/src/script/components/windows-form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ export class WindowsForm extends AppPackageFormBase {
color: #757575;
}
#languageDrop sl-menu-item:focus-within::part(base) {
color: #ffffff;
background-color: #4F3FB6;
}
#languageDrop sl-menu-item::part(base):hover{
color: #ffffff;
background-color: #4F3FB6;
Expand Down
10 changes: 10 additions & 0 deletions components/manifest-editor/src/components/manifest-info-form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,16 @@ export class ManifestInfoForm extends LitElement {
width: 100%;
}
sl-menu-item:focus-within::part(base) {
color: #ffffff;
background-color: #4F3FB6;
}
sl-menu-item::part(base):hover{
color: #ffffff;
background-color: #4F3FB6;
}
.error-color-field{
border: 1px solid #eb5757 !important;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ export class ManifestPlatformForm extends LitElement {
sl-menu {
width: 100%;
}
sl-menu-item:focus-within::part(base) {
color: #ffffff;
background-color: #4F3FB6;
}
sl-menu-item::part(base):hover{
color: #ffffff;
background-color: #4F3FB6;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,11 @@ export class ManifestSettingsForm extends LitElement {
line-height: 16px;
margin-left: .25em;
}
sl-menu-item:focus-within::part(base) {
color: #ffffff;
background-color: #4F3FB6;
}
sl-menu-item::part(base):hover {
color: #ffffff;
Expand Down

0 comments on commit 495ac02

Please sign in to comment.