From b9e90c79e9509135b5a07d44319707d2b54340e6 Mon Sep 17 00:00:00 2001 From: Justin Willis Date: Mon, 6 Feb 2023 10:18:13 -0800 Subject: [PATCH] fix(): roll back relativity check for now (#3821) fixes #[issue number] ## PR Type ## Describe the current behavior? ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis (HE / HIM) --- .../manifest-validation/src/validations.ts | 36 +------------------ 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/libraries/manifest-validation/src/validations.ts b/libraries/manifest-validation/src/validations.ts index cf9704c06..7a30f8dd1 100644 --- a/libraries/manifest-validation/src/validations.ts +++ b/libraries/manifest-validation/src/validations.ts @@ -255,41 +255,7 @@ export const maniTests: Array = [ quickFix: true, test: (value: string) => { if (value && typeof value === "string" && value.length > 0) { - try { - // get current manifest - const currentMani = currentManifest; - - const url = value; - //console.log("test url", url); - - // is url relative to scope - let relativeToScope = false; - if (currentMani && currentMani.scope) { - //console.log("test scope", currentMani?.scope); - // is url relative to currentMani.scope - const scopeUrl = currentMani.scope; - //console.log("scope url", scopeUrl); - - if (url.startsWith(scopeUrl)) { - relativeToScope = true; - } - else { - relativeToScope = false; - } - } - else if (currentMani && !currentMani.scope && (url.startsWith("/") || url.startsWith("https"))) { - relativeToScope = true; - } - else { - relativeToScope = false; - } - - return relativeToScope; - - } - catch { - return false; - } + return true; } else { return false;