Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG icon not supported #4374

Closed
denyaalt opened this issue Sep 12, 2023 · 3 comments
Closed

SVG icon not supported #4374

denyaalt opened this issue Sep 12, 2023 · 3 comments
Assignees
@jgw96
Labels
feature request 📬

Comments

@denyaalt
Copy link

denyaalt commented Sep 12, 2023 •
edited
Loading

Hi,
In the manifest file, we can specify one icon in SVG format, but PWABuilder does not detect its presence.

изображение

изображение

Do you have an implementation or a solution in mind?

PWABuilder should be able to work with SVG icons.
@jgw96
Copy link
Contributor

jgw96 commented Sep 13, 2023

THanks for opening an issue with us! So, we should check the latest browser support again, but traditionally SVG's in the web manifest was not well supported on all OS's, which is why we recommend PNG icons. I see the Web Manifest spec mentions SVG icons now though. @denyaalt do you have the URL to your PWA? If you try to install it directly from Edge, does your icon display as expected?

@denyaalt
Copy link
Author

I checked, Edge (116.0.1938.81) successfully processed my SVG icon and placed it on the desktop.
Even if some browsers do not support SVG (which is unlikely), we are targeting Android and iOS, and the developer has the right to independently choose which icon format to use.
Please add SVG icons to PWABuilder.

@jgw96 jgw96 mentioned this issue Sep 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 2, 2023
@jgw96
Svg support (#4392)
7b9d377 
fixes #4374 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->

We were only checking for PNG icons, but as the user pointed out, SVG is
supported too.

## Describe the new behavior?
Updated the test to check for either PNG or SVG, along with updating the
test message to reflect this change.

## PR Checklist

- [ x] Test: run `npm run test` and ensure that all tests pass
- [ x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information
@beth-panx
Copy link
Contributor

closed by #4392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgw96 jgw96

Labels
feature request 📬
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beth-panx @jgw96 @denyaalt