Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics improvements #3874

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Analytics improvements #3874

merged 6 commits into from
Feb 28, 2023

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Feb 27, 2023

fixes #3871

PR Type

Other... Please describe: Analytics

Describe the new behavior?

SessionID is now sent in our analytics + sent to the pwabuilder services as a header

PR Checklist

  • [ x] Test: run npm run test and ensure that all tests pass
  • [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • [x ] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Feb 27, 2023

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3874.eastus2.azurestaticapps.net

amrutha95
amrutha95 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@amrutha95 amrutha95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3874.eastus2.azurestaticapps.net

@jgw96 jgw96 added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit f4e6f11 Feb 28, 2023
@jgw96 jgw96 deleted the analytics-again branch February 28, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrutha95 amrutha95 amrutha95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VSCODE] Analytics changes to match up with backend changes
2 participants
@jgw96 @amrutha95