Giving developers control over the Windows Icon Background color option in the packaging form #3892
Conversation
…e we use outside the modal just a diff color
Share feature ready for testing
…ent with manifesT
…eport card page and the share card + centered the error rings on the share card
…kage (#3850) fixes #3849 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Feature ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> You need to have a SW to package ## Describe the new behavior? You no longer need a SW to package. Todo list sorted by required > highly rec > rec > optional to promote the things we think are important first. ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Justin Willis <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Judah Gabriel Himango <[email protected]>
…ing for all tests to be done
…rote a core component we were using so im struggling to get things back to how they were
|
Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3892.eastus2.azurestaticapps.net |
ghost
added
the
|
Hey @Jaylyn-Barbee along with the review, would you mind updating this branch from the base branch when you get some time? Let me know if I can help in some way. Thanks! |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3892.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3892.eastus2.azurestaticapps.net |
|
@khmyznikov to make sure "transparent" is an accepted value for the new icon generator |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-3892.eastus2.azurestaticapps.net |
fixes #3861
PR Type
Bugfix / Feature
Describe the current behavior?
Right now, we use the developers
manifest.background_coloras a default and"transparent"as a fallback for the Windows icon background color.Describe the new behavior?
Now we have a color pick in the windows packaging form that gives the developer complete control over that field.
PR Checklist
npm run testand ensure that all tests passAdditional Information
This PR contains some other minor bug fixes and updates to the way we use the
sl-selectcomponent as it was rewritten by shoelace recently.