Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest path fix #4476

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Manifest path fix #4476

merged 3 commits into from
Nov 2, 2023

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Oct 23, 2023

fixes #4157

PR Type

Bugfix

Describe the current behavior?

As the user showed in the issue, it is possible to get into a state where getManifest returns nothing, which would cause the generated manifest to not be linked to the index.html.

Describe the new behavior?

We now pass the manifestPath directly as a "backup" value, which would avoid any, unlikely, breakage as it is just a backup value to how things normally work.

PR Checklist

  • [x ] Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • [x ] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service
Copy link
Contributor

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4476.centralus.2.azurestaticapps.net

@jgw96 jgw96 merged commit 26d54af into staging Nov 2, 2023
4 checks passed
@jgw96 jgw96 deleted the manifest-path-fix branch November 2, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant