Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4157
PR Type
Bugfix
Describe the current behavior?
As the user showed in the issue, it is possible to get into a state where
getManifest
returns nothing, which would cause the generated manifest to not be linked to the index.html.Describe the new behavior?
We now pass the manifestPath directly as a "backup" value, which would avoid any, unlikely, breakage as it is just a backup value to how things normally work.
PR Checklist
npm run test
and ensure that all tests passAdditional Information