[Site][Accessibility] Proper headings defined on every page across docs and PWABuilder.com #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4478.centralus.2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4478.centralus.2.azurestaticapps.net |
…r into jay/heading-update
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4478.centralus.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4478.centralus.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4232
PR Type
Bugfix
Describe the current behavior?
View problem in issue.
Describe the new behavior?
Each page has an H1 and proper headings underneath. Certain text that acted as headers but weren't technically headers are now headers in the HTML.
PR Checklist
npm run testand ensure that all tests passAdditional Information
This is a joint PR of the work from both myself and @zateutsch