Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site][Accessibility] Proper headings defined on every page across docs and PWABuilder.com #4478

Merged
merged 8 commits into from
Oct 27, 2023
+14 −6
Merged

[Site][Accessibility] Proper headings defined on every page across docs and PWABuilder.com #4478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c409a83
added heading on report card page
Jaylyn-Barbee Aug 30, 2023
53b7108
made sure every page has an h1
Jaylyn-Barbee Aug 30, 2023
c5759ad
update
Jaylyn-Barbee Oct 19, 2023
61ec7ea
converted sidebard headers to h2s
zateutsch Oct 24, 2023
7777936
Merge branch 'staging' into jay/heading-update
Jaylyn-Barbee Oct 25, 2023
8e5e60f
typo fix
Jaylyn-Barbee Oct 26, 2023
6836fe8
Merge branch 'jay/heading-update' of github.com:pwa-builder/PWABuilde…
Jaylyn-Barbee Oct 26, 2023
9db2b3e
Merge branch 'staging' into jay/heading-update
beth-panx Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/pwabuilder/src/script/pages/app-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export class AppReport extends LitElement {
"file_handlers": "Be a default handler for certain filetypes with file_handlers",
"handle_links": "Open links as an app with handle_links",
"protocol_handlers": "Create a custom protocol_handler",
"edge_side_panel": "Increase reach by partcipating in the edge_side_panel",
"edge_side_panel": "Increase reach by participating in the edge_side_panel",
"widgets": "Increase reach with widgets"
}

Expand Down Expand Up @@ -498,6 +498,10 @@ export class AppReport extends LitElement {
margin: 0;
}

.visually-hidden {
font-size: 0;
}

#site-url {
text-overflow: ellipsis;
overflow: hidden;
Expand Down Expand Up @@ -2880,7 +2884,10 @@ export class AppReport extends LitElement {
${this.proxyLoadingImage || this.appCard.iconURL.length === 0 ? html`<span class="proxy-loader"></span>` : html`<img src=${this.appCard.iconURL} alt=${this.appCard.iconAlt} />`}
</div>
<div id="card-info" class="flex-row">
<h1 id="site-name">${this.appCard.siteName}</h1>
<h1 id="site-name">
${this.appCard.siteName}
<span class="visually-hidden" aria-live="polite">Report card page for ${this.appCard.siteName}</span>
</h1>
<p id="site-url">${this.appCard.siteUrl}</p>
<p id="app-card-desc" class="app-card-desc-desktop">${this.truncateString(this.appCard.description)}</p>
</div>
Expand Down
3 changes: 2 additions & 1 deletion apps/pwabuilder/src/script/pages/qualification/app-token.style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,10 @@ export default css`
font-size: 14px;
}

#words p:nth-child(1) {
#words h1 {
font-size: 24px;
font-weight: 700;
margin: 0;
}
#words p:nth-child(2) {
width: 55%;
Expand Down
4 changes: 2 additions & 2 deletions apps/pwabuilder/src/script/pages/qualification/app-token.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export function renderAppCard(
/>
</div>
<div id="words">
<p>${appCard.siteName}</p>
<h1>${appCard.siteName}</h1>
<p>${appCard.siteUrl}</p>
<p class="app-desc">${appCard.description}</p>
</div>
Expand Down Expand Up @@ -315,7 +315,7 @@ export function renderAppCard(
/>
</div>
<div id="words">
<p>${appCard.siteName}</p>
<h1>${appCard.siteName}</h1>
<p>${appCard.siteUrl}</p>
<p class="app-desc">${appCard.description}</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/sidebarGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function constructMenuItemLineString(article: Article): string {
}

function constructHeaderLineString(childMenu: ChildMenu): string {
return `\n\n\- **${childMenu.header}**`;
return `\n\n- <h2>${childMenu.header}</h2> \n`;
}

function constructTopLevelNavString(activeHeader: string): string {
Expand Down
Loading