Transparent new default for Windows Icon Backgrounds. #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed typo in test package pane. Removed ability to generate screenshots.
|
Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4571.centralus.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4401
PR Type
Feature
Describe the current behavior?
Manifest background color is default for icon background
Describe the new behavior?
Transparent is default for icon background
PR Checklist
npm run testand ensure that all tests passAdditional Information
This PR also disables the ability to generate screenshots as we feel generating base64 strings into peoples manifest is creating an inefficient system and people don't understand why its inefficient and trusting that PWABuilder is doing the right thing when it isn't. Part of the temporary solution described here #4550