Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector codelist error #35

Closed
siwhitehouse opened this issue Jul 6, 2019 · 4 comments
Closed

Sector codelist error #35

siwhitehouse opened this issue Jul 6, 2019 · 4 comments
Assignees

Comments

@siwhitehouse
Copy link
Contributor

Publish What You Fund have received the following email:

Hi,

We are testing our activity file against the PWYF data quality tester and we are getting an error on sector code (see screenshot below). The case seems to be unique for sector code 43060, which is present in the IATI sector code list. Hope you can help us with this issue.

Thank you.

errorMsg

Regards,

-Lulu

Consultant

SPOP- Asian Development Bank

Lulu references http://reference.iatistandard.org/203/codelists/Sector/ which is the replicated DAC 5 digit sector codelist and includes the code '43060': "Disaster Risk Reduction".

@siwhitehouse
Copy link
Contributor Author

Neither https://raw.githubusercontent.com/pwyf/data-quality-tester/develop/codelists/1/Sector.json and https://raw.githubusercontent.com/pwyf/data-quality-tester/develop/codelists/2/Sector.json contain a code '43060' (note: I'm not certain this where the DQT checks sample files against IATI codelists).

The /develop/codelists folder's last commit was on 14 Dec 2017.

Each of those Sector codelists files have the following metadata

"metadata": {"url": "http://www.oecd.org/dac/stats/dacandcrscodelists.htm", "name": "DAC 5 Digit Sector"

Checking the file at https://webfs.oecd.org/crs-iati-xml/Lookup/DAC-CRS-CODES.xml I can see a code for '43060'.

My initial best guess is that the codelists need to be brought up to date with the latest version of the 5 digit DAC codes that are implemeted by IATI.

@siwhitehouse siwhitehouse self-assigned this Jul 6, 2019
@andylolz
Copy link
Contributor

andylolz commented Jul 6, 2019

My initial best guess is that the codelists need to be brought up to date with the latest version of the 5 digit DAC codes that are implemeted by IATI.

Yes, you’re right.

Looks like I added this codelist code to IATI (IATI/IATI-Codelists-NonEmbedded#283) but forgot to update it in the DQT.

There’s a flask command to do this (flask refresh-codelists), but doesn’t seem to be working at the moment.

@andylolz
Copy link
Contributor

andylolz commented Jul 6, 2019

Okay, flask refresh-codelists works now, so I’ll leave this with you.

@siwhitehouse
Copy link
Contributor Author

This fix has been applied on the DQT server and the file that Lulu was testing no longer causes an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants