Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use with blocks for closing and opening connections #422

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Use with blocks for closing and opening connections #422

merged 1 commit into from
Nov 23, 2022

Conversation

PerchunPak
Copy link
Member

Fixes #337.

@ItsDrike ItsDrike added status: needs review Author is waiting for someone to review and approve area: protocol Related to underlying networking protocol labels Oct 16, 2022
@PerchunPak PerchunPak force-pushed the use-with-blocks-for-closing-and-opening-connections branch from 4afc931 to a9db601 Compare October 24, 2022 13:26
ItsDrike
ItsDrike requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just some minor things and it should be good to go

mcstatus/protocol/connection.py Outdated Show resolved Hide resolved
mcstatus/protocol/connection.py Outdated Show resolved Hide resolved
mcstatus/protocol/connection.py Outdated Show resolved Hide resolved
tests/test_server.py Show resolved Hide resolved
tests/test_server.py Show resolved Hide resolved
tests/test_server.py Show resolved Hide resolved
@ItsDrike ItsDrike added type: bug Something isn't working type: feature New request or feature state: waiting for author Waiting for author to address a review or respond to a comment and removed status: needs review Author is waiting for someone to review and approve labels Nov 8, 2022
@PerchunPak PerchunPak force-pushed the use-with-blocks-for-closing-and-opening-connections branch from a9db601 to 7613771 Compare November 8, 2022 13:34
@ItsDrike ItsDrike added state: approved The issue has received an approval from the maintainers and removed state: waiting for author Waiting for author to address a review or respond to a comment labels Nov 8, 2022
@ItsDrike ItsDrike merged commit 5f735b0 into py-mine:master Nov 23, 2022
@PerchunPak PerchunPak deleted the use-with-blocks-for-closing-and-opening-connections branch November 23, 2022 17:05
@PerchunPak PerchunPak mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDrike ItsDrike ItsDrike approved these changes

Assignees
No one assigned
Labels
area: protocol Related to underlying networking protocol state: approved The issue has received an approval from the maintainers type: bug Something isn't working type: feature New request or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket not closable before program end.
2 participants
@PerchunPak @ItsDrike