Enable pre-commit.ci and enable config file sorting #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolCat467
changed the title
PerchunPak
approved these changes
Dec 15, 2023
|
@ItsDrike looks like it also requires yours review, as you're code owner of the CI (including pre-commit config) |
This frequency can be reduced. Those PRs are a low priority as most do not affect the code that mcstatus is leveraging. If there's a bot that could automatically approve and merge dependabot updates that pass CI tests, that would be amazing. |
ItsDrike
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #694
This pull request enables pre-commit.ci and enables a few of the other https://github.com/pre-commit/pre-commit-hooks fixes, these being
end-of-file-fixer,mixed-line-ending, andsort-simple-yaml.sort-simple-yamlin particular is only sorting the pre-commit config file so that future changes will be in an ordered fashion.Edit:
One important detail, someone who is an owner of the repository/github organization has to give pre-commit.ci access to the repository so whatever bot they have can make the pull requests. You can find it on their official site at https://pre-commit.ci/