Fix incorrect signed noise terms for DiscreteAdditiveNoiseModel #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Saldanha <[email protected]>
|
Thanks a lot! Do you mind adding a unit test as well that tests this explicitly? |
|
Yes, will do when I get a chance! |
|
Hey, any chance to prepare a small test? |
bloebp
approved these changes
Oct 22, 2024
|
@all-contributors please add @GregVS for code |
|
I've put up a pull request to add @GregVS! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I believe the noise terms for the DiscreteAdditiveNoiseModel are being computed with the wrong sign. The noise terms are added to the predicted value, therefore they should be computed by subtracting the predicted value from the true value. Currently, they are computed the other way, which would lead the noise distribution to be incorrect. They are computed correctly in the PostlinearNoiseModel implementation; I've updated the DiscreteAdditiveNoiseModel to function the same.