Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyos meta repo] Sign pypi releases using sigstore #146

Closed
lwasser opened this issue Mar 26, 2024 · 4 comments · Fixed by #156
Closed

[pyos meta repo] Sign pypi releases using sigstore #146

lwasser opened this issue Mar 26, 2024 · 4 comments · Fixed by #156
Assignees
Labels
automation Automate workflows and CI help wanted Extra attention is needed sprintable

Comments

@lwasser
Copy link
Member

lwasser commented Mar 26, 2024

In this issue @webknjaz suggested looking into sigstore as a way to sign releases and add additional security to our builds. myself and @willingc have implemented everything else in that issue short of sigstore. this can be implemented in a future release / effort! Notes on it below:

Finally, there's a way to sign releases with Sigstore that's showcased @ https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#signing-the-distribution-packages (might need adapting to take your trigger into account). This is optional but with the support for uploading GPG signatures removed from the PyPI, it's probably going to be the future replacement so I decided to include a configuration example that also relies on OIDC but doesn't need much configuration.

@lwasser lwasser added help wanted Extra attention is needed sprintable automation Automate workflows and CI labels Mar 26, 2024
@willingc willingc added this to the April 2024 Release Planning milestone Mar 29, 2024
@blink1073
Copy link
Collaborator

@lwasser I'm happy to take on this one. Where would you like this applied, only in this repo?

@lwasser
Copy link
Member Author

lwasser commented May 23, 2024

@blink1073 that would be amazing! yes!! if you are able to document what you do in applying it that would be super helpful for when we create a tutorial on ci workflows to publish to pypi. thank you!!

@lwasser lwasser changed the title Sign pypi releases using sigstore [pyos meta repo] Sign pypi releases using sigstore May 23, 2024
@willingc
Copy link
Collaborator

@blink1073 Thanks for pitching in! Great to see you over here and at PyCon. ☀️

@blink1073
Copy link
Collaborator

Great to see you too @willingc, happy to help!

if you are able to document what you do in applying it that would be super helpful for when we create a tutorial on ci workflows to publish to pypi. thank you!!

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Automate workflows and CI help wanted Extra attention is needed sprintable
Projects
Development

Successfully merging a pull request may close this issue.

3 participants