Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.4 #202

Closed
lwasser opened this issue Aug 1, 2024 · 5 comments
Closed

Release v1.3.4 #202

lwasser opened this issue Aug 1, 2024 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@lwasser
Copy link
Member

lwasser commented Aug 1, 2024

Hi everyone! we need to create a new release of this package that will fix some issues with how the contributor data is parsed

https://github.com/pyOpenSci/pyopensci.github.io/pull/452/files#diff-c4bf8c3b089fbd17d00af382bbaa613a9e20c8d78363cf44785fa59047a96d77L426

notice now people are being moved to emeritus advisory roles by mistake because of a bug i found and fixed here #200
@willingc also fixed a test bug here: #199 that was causing pr's to fail. If anyone is open to generating a update change log with these contributions (plus the contributions from the pyopensci sprint at scipy 2024 that pr is welcome!!

then we can make a new release and fix our website build.

so the steps needed

  1. update the change log to represent the current changes made (we haven't kept it up to date). submit a pr and merge it
  2. create a new release on github
  3. that release will trigger a push to pypi!
    then we can rerun the contributor workflow.
@lwasser lwasser added the help wanted Extra attention is needed label Aug 1, 2024
@willingc
Copy link
Collaborator

willingc commented Aug 1, 2024

@lwasser Let's troubleshoot: #200 (comment) prior to release.

Contributors, please feel free to do the other release steps. 😄

@lwasser lwasser changed the title New patch release is required! Release v1.3.4 Aug 1, 2024
@lwasser
Copy link
Member Author

lwasser commented Aug 1, 2024

ok i think @willingc please correct me if i'm wrong. we are now really ready for a new patch release? given #203 and the code cov change in #205

@willingc
Copy link
Collaborator

willingc commented Aug 1, 2024

Go for it @lwasser. It was good to go before my CI change too (for future reference) 😄

@lwasser
Copy link
Member Author

lwasser commented Aug 1, 2024

thank you @willingc ❤️ !! i also didn't know about the coverage settings. i am going to use that in stravalib as sometimes it complains if something is 1% off.

@willingc
Copy link
Collaborator

willingc commented Aug 3, 2024

Closed by #206

@willingc willingc closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants