Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add dependencies to the pyproject.toml #105

Closed
lwasser opened this issue Oct 2, 2023 · 4 comments
Closed

How to add dependencies to the pyproject.toml #105

lwasser opened this issue Oct 2, 2023 · 4 comments

Comments

@lwasser
Copy link
Member

lwasser commented Oct 2, 2023

@sneakers-the-rat added a really helpful comment about how to declare deps across tools. We should incorporate this into the guide. i don't think we cover declaring deps explicitly yet. it came up in the tests section but i'm not sure all of that info belongs there. rather we should link to a page / section on declaring dependencies.

@ucodery
Copy link
Collaborator

ucodery commented Apr 7, 2024

I believe this was the comment referenced #104 (comment)

Given that we have settled on hatch for the rest of the guide, I would say we focus only on the universal project.dependencies for direct dependencies. For secondary or alternate-installs we could show either project.optional-depenencies and/or the tool.hatch.envs.*.dependencies.

I assume this is also the place that we want to directly address version strings and version ranges, as defined in PEP 440 and also explained in the packaging docs also name normalization

@sneakers-the-rat
Copy link
Contributor

This was merged recently: #191

I dont think that covered optional dependencies and didnt try to do a comprehensive overview bc that is the "tutorial" document instead of a "reference" document, but yes lets make sure we cover that :)

@ucodery
Copy link
Collaborator

ucodery commented Apr 8, 2024

Ah that looks so good! And I notice we do already address optional-dependencies at here and here.

With all that, I wonder if there is anything more we need?

@lwasser
Copy link
Member Author

lwasser commented Apr 9, 2024

oh funny. i'm just doing a small issue cleanup and was about to post the links that @ucodery mentioned above.

I think all of the work @sneakers-the-rat has already done has addressed this! let's close !! many thanks all!!

@lwasser lwasser closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants