Issue DEBUG-only failure if STL wrappers attempt to allocate size of -1 #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this is the best way to approach this issue, from either code or design point of view. The intent here is that if user code omits a __len__ definition for a sequence-like object, we fail with a helpful error message, rather than just "bad_alloc".
|
Seems reasonable to me. Can you add a test case for this to the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to approach this issue, from either code or design point of view. The intent here is that if user code omits a len definition for a sequence-like object, we fail with a helpful error message, rather than just "bad_alloc".