Implementation of Python's 'with' statement as py::with #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
force-pushed
the
py-with
branch
4 times, most recently
from
f1603eb
to
07db204
Compare
YannickJadoul
force-pushed
the
py-with
branch
2 times, most recently
from
6e3d032
to
7174c5a
Compare
…nto a sightly different version of those getters got merged into master
|
Hi Yannick, this is certainly a neat idea and was clearly a lot of work. However, for me the C++ form of this feature is simply too awkward, and I find the implementation too complex to justify shipping a rather "niche" feature in header files that will be included downstream by all projects using pybind11. So I'll close this for now. If the implementation was substantially simpler, in a separate header file that is not used by default, and didn't require changes to central pybind11 logic, I might consider it. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @martinRenou and @bstaletic on Gitter, a
withstatement complying with the semantics of PEP 343 might be a useful utility to add to the pybind11 toolbox.Since C++ will crash if an exception gets thrown while another one is already active, it seems impossible to have a safe RAII implementation of this. But for almost all purposes, this version, taking a function or lambda, should be sufficient.
This PR depends on @martinRenou's PR #1641 adding getters to
py::error_already_set.