PYBIND11_TLS_REPLACE_VALUE should use macro argument value in Python … #1683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PYBIND11_TLS_REPLACE_VALUE
macro doesn't actually use thevalue
argument when using the new Python TLS API (3.7+). Instead, it always useststate
as the argument. This works because the two placesPYBIND11_TLS_REPLACE_VALUE
is used in the code the argument iststate
.pybind11/include/pybind11/pybind11.h
Line 1890 in e2b884c
pybind11/include/pybind11/pybind11.h
Line 1963 in e2b884c
However, for correctness, and for anyone piggybacking on pybind's cross-version TLS support (like me!) it should use the
value
argument