Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a 2.2 release #953

Closed
6 tasks done
jagerman opened this issue Jul 21, 2017 · 12 comments
Closed
6 tasks done

Make a 2.2 release #953

jagerman opened this issue Jul 21, 2017 · 12 comments
Milestone

Comments

@jagerman
Copy link
Member

jagerman commented Jul 21, 2017

We have a decent amount of new features and bug fixes for a new stable v2.2 release. Some big features (embedding support seems the biggest), lots of minor ones, and various bug fixes have landed into master over the last four months. I'm not suggesting we release it tomorrow, but I think we should start thinking about where to draw the line for 2.2.

PRs I think we should aim to merge:

Other features in the queue that I think might not make it:

  • Revising the design of type_caster<T>::load() #864 (Revising type casters) - I think this is going to be a pretty significant change, and likely to go through a fair amount of discussion/suggestions/changes from start to finish. I'm not opposed to including it if its done soon, but of course I also think it's important to get it right.
  • WIP: Python 3 enums #781 (python 3.4 enums) - this is still marked WIP and, I guess, still in progress. I think the last discussion was that it was going to be separate from enum_<> due to backwards-compatibility issues with how enum_ worked; beyond that I'm not entirely sure of the status.

Thoughts?

@jagerman jagerman added this to the v2.2 milestone Jul 21, 2017
@dean0x7d
Copy link
Member

Yeah, seems like a good time for a new release. There's a good number of bug fixes and some nice new features.

I'd suggest postponing #934 for the next release, so it gets some time in master just in case there are any backward compatibility concerns. Also, it's related to #864 so if we find any need to adjust the casters it would be good to keep everything in one release and change things only once.

For the rest of the PRs, I very much agree with your assessment.

@garth-wells
Copy link

garth-wells commented Jul 25, 2017

Would be great if #960 could make it into a 2.2 release.

@after5cst
Copy link

(From the peanut gallery): initial experience with pybind11 has been good other than brief documentation. Could really use #805 as soon as available.

@dean0x7d
Copy link
Member

dean0x7d commented Aug 23, 2017

Updates:

So, my thinking is: postpone the first one, finish the other 4 and call it a release. Would that work or is there anything else?

@wjakob
Copy link
Member

wjakob commented Aug 23, 2017

I'm not so happy with #901 yet, so dropping that for now sounds good to me. +1 for the rest.

@jagerman
Copy link
Member Author

Sounds good to me.

@dean0x7d
Copy link
Member

All of the PRs discussed above have been merged. I've gone over the changelog one more time, fixed some typos, noted some of the last-minute additions and added a short entry for the upgrade guide: 4c54044

If there's nothing else, I think this might be good to go.

@garth-wells
Copy link

See #1046, which I think is due to changes in #1038.

@dean0x7d
Copy link
Member

See #1046, which I think is due to changes in #1038.

Fixed in #1047.

@wjakob
Copy link
Member

wjakob commented Aug 31, 2017

I'm ready to push the button. @jagerman, anything left from your end?

@jagerman
Copy link
Member Author

Nope, I think we're good to go!

@wjakob
Copy link
Member

wjakob commented Aug 31, 2017

Ok, done! -- the PyPi package is pushed, and the one on conda forge will be shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants