Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether async is supported? #13

Closed
kevinkelin opened this issue Nov 22, 2023 · 2 comments
Closed

Whether async is supported? #13

kevinkelin opened this issue Nov 22, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kevinkelin
Copy link

pycasbin has already support Async Enforcer, so does this repo has a plan to support async?

@casbin-bot
Copy link

@techoner @Nekotoxin

@casbin-bot casbin-bot added the enhancement New feature or request label Nov 22, 2023
@kevinkelin
Copy link
Author

I check pycasbin code, the problem is not redis-watcher,because in AsyncInternalEnforcer,

  if self.watcher and self.auto_notify_watcher:
      if callable(getattr(self.watcher, "update_for_add_policy", None)):
          self.watcher.update_for_add_policy(sec, ptype, rule)
      else:
          self.watcher.update()

self.watcher.update_for_add_policy(sec, ptype, rule) is not the way call async func

so, close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants