feat: softdelete rule model #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load rules from db before making changes
- improved comments
|
@trbtm Hi,
|
|
@leeqvip Hi, I added an example demonstrating my approach. To your points:
Best |
leeqvip
requested changes
Jul 7, 2024
| self, | ||
| engine, | ||
| db_class=None, | ||
| db_class_softdelete_attribute=None, |
There was a problem hiding this comment.
Here you can judge according to the is_deleted attribute of db_class, the default value is None
| CasbinSoftDeleteRule.is_deleted, | ||
| ) | ||
| # Create the Enforcer, etc. | ||
| e = casbin.Enforcer("path/to/model.conf", adapter) |
There was a problem hiding this comment.
Please write it directly in the readme, in a separate section
leeqvip
approved these changes
Jul 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
# [1.4.0](v1.3.0...v1.4.0) (2024-07-08) ### Features * support for soft deletion of casbin rules ([#72](#72)) ([8911c16](8911c16))
|
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have the option for having soft delete rules in the database to be able to possibly track fields like
etc.