fix interaction between extra != 'ignore'
and from_attributes=True
#1275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is a bugfix to set the interaction between
extra
andfrom_attributes
to match the pre-2.7 behaviour.To be honest, I don't love it, basically if
from_attributes
is set thenextra
basically always functions as "ignore". I can sort of see why, and we didn't intend to change it in 2.7, but I wonder if there's more satisfying long-term behaviour.Related issue number
Fixes pydantic/pydantic#9242
Fixes pydantic/pydantic#9250
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin