New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl not consistently replaced with ⌘ on macs #1447

Closed

kecnry opened this issue Sep 15, 2023 · 0 comments · Fixed by #1449

kecnry commented Sep 15, 2023

On macs, Ctrl+K is replaced with ⌘+K in the search overlay, but not in the button that launches the overlay on the top bar. The replacement seems to happen in https://github.com/pydata/pydata-sphinx-theme/blob/bd67c18a1904b0301de0fb285792b87672e403ce/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js#L256C36-L256C36 but the selector only matches the form and not the button.

Screenshot from https://pydata-sphinx-theme.readthedocs.io/en/stable/index.html

drammock mentioned this issue

show ⌘ on Mac in both search button and search input field #1449

Merged

drammock closed this as completed in #1449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment