Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_attrs for NamedArray #8306

Open
Tracked by #8238
dcherian opened this issue Oct 14, 2023 · 0 comments
Open
Tracked by #8238

keep_attrs for NamedArray #8306

dcherian opened this issue Oct 14, 2023 · 0 comments
Labels
API design topic-NamedArray Lightweight version of Variable

Comments

@dcherian
Copy link
Contributor

dcherian commented Oct 14, 2023

What is your issue?

Copying over @max-sixty's comment from #8304 (comment)

I haven't been in touch with the NameArray discussions so forgive a glib comment — but re #3891 — this would be a "once-in-a-library" opportunity to always retain attrs in aggregations, removing the keep_attrs option in methods.

(Xarray could still handle them as it wished, so xarray's external interface wouldn't need to change immediately...)

@pydata/xarray Should we just delete the keep_attrs kwarg completely for NamedArray and always propagate attrs? obj.attrs.clear() seems just as easy to type.

@dcherian dcherian added API design topic-NamedArray Lightweight version of Variable labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design topic-NamedArray Lightweight version of Variable
Projects
None yet
Development

No branches or pull requests

1 participant