Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zarr V3 support: use dimension_names array metadata rather than user attribute _ARRAY_DIMENSIONS #9668

Closed
rabernat opened this issue Oct 23, 2024 · 0 comments · Fixed by #9669
Closed

Zarr V3 support: use dimension_names array metadata rather than user attribute _ARRAY_DIMENSIONS #9668

rabernat opened this issue Oct 23, 2024 · 0 comments · Fixed by #9669
Labels
topic-zarr Related to zarr storage library

Comments

@rabernat
Copy link
Contributor

What is your issue?

Zarr V3 now explicitly supports dimension names on arrays (see Array API docs.

This makes our _ARRAY_DIMENSIONS special attribute unnecessary.

xarray/xarray/backends/zarr.py

Lines 54 to 55 in b133fdc

# need some special secret attributes to tell us the dimensions
DIMENSION_KEY = "_ARRAY_DIMENSIONS"

However, we are still using _ARRAY_DIMENSIONS with V3 in Xarray.

It would be great to fix this before we release V3 support so we don't start putting V3 data out into wild with this attribute set.
@rabernat rabernat added topic-zarr Related to zarr storage library needs triage Issue that has not been reviewed by xarray team member labels Oct 23, 2024
@rabernat rabernat mentioned this issue Oct 24, 2024
Merged
3 tasks
@TomNicholas TomNicholas removed the needs triage Issue that has not been reviewed by xarray team member label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-zarr Related to zarr storage library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use zarr v3 dimension_names rabernat/xarray
2 participants
@rabernat @TomNicholas