Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest capture uses match, not message #3011

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jun 10, 2019

  • Fully documented, including whats-new.rst for all changes and api.rst for new API

message was always going being ignored, and with the newer pytest version raises a warning that an unknown kwarg is supplied

@max-sixty
Copy link
Collaborator Author

Tests pass apart from py36-dask-dev, which fail on master: https://travis-ci.org/pydata/xarray/builds/543887984

@dcherian
Copy link
Contributor

LGTM and I didn't see any pytest warnings in the test logs :)

@max-sixty max-sixty merged commit f3efb5b into pydata:master Jun 11, 2019
@max-sixty max-sixty deleted the pytest-match branch June 11, 2019 15:01
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 24, 2019
* master: (31 commits)
  Add quantile method to GroupBy (pydata#2828)
  rolling_exp (nee ewm) (pydata#2650)
  Ensure explicitly indexed arrays are preserved (pydata#3027)
  add back dask-dev tests (pydata#3025)
  ENH: keepdims=True for xarray reductions (pydata#3033)
  Revert cmap fix (pydata#3038)
  Add "errors" keyword argument to drop() and drop_dims() (pydata#2994) (pydata#3028)
  More consistency checks (pydata#2859)
  Check types in travis (pydata#3024)
  Update issue templates (pydata#3019)
  Add pytest markers to avoid warnings (pydata#3023)
  Feature/merge errormsg (pydata#2971)
  More support for missing_value. (pydata#2973)
  Use flake8 rather than pycodestyle (pydata#3010)
  Pandas labels deprecation (pydata#3016)
  Pytest capture uses match, not message (pydata#3011)
  dask-dev tests to allowed failures in travis (pydata#3014)
  Fix 'to_masked_array' computing dask arrays twice (pydata#3006)
  str accessor (pydata#2991)
  fix safe_cast_to_index (pydata#3001)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants