Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires=["setuptools"], in setup.py is wrong #596

Closed
socketpair opened this issue Jan 14, 2023 · 4 comments
Closed

install_requires=["setuptools"], in setup.py is wrong #596

socketpair opened this issue Jan 14, 2023 · 4 comments

Comments

@socketpair
Copy link

socketpair commented Jan 14, 2023

Actually, setuptools is dev-requirement. It's required only to build the package.

It's not required for Cerberus to work when it is installed.

Please remove this from requirements becuse it adds extra packaes in target systems. For example, Fedora's python3-cerberus depends on python3-setuptools, which is very bad.

@socketpair
Copy link
Author

I figured out.

cerberus/__init__.py contains code:

try:
    __version__ = get_distribution("Cerberus").version
except DistributionNotFound:
    __version__ = "unknown"

It's painfully slow (200 ms) on systems where many packages installed. This place needs to be patched.

@socketpair
Copy link
Author

socketpair commented Jan 14, 2023

skorokithakis/shortuuid#59 same shit

pkg_resources is deprecated

please either remove dynamic __version__ setup (better) or change to importlib.metadata

@socketpair
Copy link
Author

pypa/setuptools#926

@funkyfuture
Copy link
Member

thanks, this is a duplicate of #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants