You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
causes the intended defaults for constant_memory and default_date_format to be ignored
makes it impossible to provide overriding values for those defaults
because these two keywords arguments are not passed into the options passed to the underlying xlsxwriter.Workbook(). I think a fix like this is needed:
def __init__(
self,
file_alike_object,
file_type,
constant_memory=True,
default_date_format="dd/mm/yy",
**keywords
):
if "single_sheet_in_book" in keywords:
keywords.pop("single_sheet_in_book")
keywords['constant_memory'] = constant_memory # <<< new line
keywords['default_date_format'] = default_date_format # <<< new line
self.xlsx_book = xlsxwriter.Workbook(
file_alike_object, options=keywords
)
The text was updated successfully, but these errors were encountered:
The change to
XLSXWriter.__init__()
in bf0e271:constant_memory
anddefault_date_format
to be ignoredbecause these two keywords arguments are not passed into the
options
passed to the underlyingxlsxwriter.Workbook()
. I think a fix like this is needed:The text was updated successfully, but these errors were encountered: