Added python error catching #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Can you add a test for it? |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 20, 2017
Version 1.1.1 (2016/12/28) ----------------------------- * Suppress Ruby 2.4.0's warnings [#172](pygments/pygments.rb#172) * Enable `frozen_string_literal` [#173](pygments/pygments.rb#173) Version 1.1.0 (2016/12/24) ----------------------------- * Support JRuby [#170](pygments/pygments.rb#170) * Make pygments.rb thread safe [#171](pygments/pygments.rb#171) Version 1.0.0 (2016/12/11) ----------------------------- * Upgrade bundled pygments to 2.2.0-HEAD [#167](pygments/pygments.rb#167) * This includes **incompatible changes* because of upgrade of pygments. See http://pygments.org/ for details. * Relax yajl-ruby dependency to "~> 1.2" [#164](pygments/pygments.rb#164) * Python binary can be configured by `PYTMENTS_RB_PYTHON` env [#168](pygments/pygments.rb#168) * Improved error messages when python binary is missing [#158](pygments/pygments.rb#158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
python2command fails for some reason, all you get is justFailed to get header.error. This PR adds more meaningful error message.So if one for some reason (for example, when using
pyenv) have nopython2binary, one should have a meaningful notification on what's happening.