-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAIC/LOO only consider last chain in a Multitrace #2457
Comments
Hm. Intuitively I'd say we should probably merge the logp values from the traces, excluding tuning samles. It would be strange to use only one chain. That would though out a lot of data and the choice would be completely arbitrary. |
Looks like a bug, we should just combine the traces when njobs>1. |
Hmm, I think the simplest solution here is, when iterating over a multi trace, to iterate over all chains, not just the last chain, as is currently done. |
Is that how https://github.com/stan-dev/loo compute the loo/waic? Is it better to just combine all the traces together? |
See this gist for a demonstration. Of course, the WAIC values across difference chains should not be too different, if the sampling has been effective. This may also affect other stat functions, I haven't checked yet.
@aseyboldt thoughts on what the correct behavior should be here?
The text was updated successfully, but these errors were encountered: