Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling from GaussianRandomWalk #3073

Closed
sachinruk opened this issue Jul 3, 2018 · 4 comments
Closed

Sampling from GaussianRandomWalk #3073

sachinruk opened this issue Jul 3, 2018 · 4 comments

Comments

@sachinruk
Copy link
Contributor

It seems that you cannot sample from a GaussianRandomWalk looking at https://github.com/pymc-devs/pymc3/blob/master/pymc3/distributions/timeseries.py#L134 or any other distribution in timeseries.py. Think this is partly due to the fact that the initial (default) distribution is defined to be Flat.

Just wondering if it's worth changing into something like uniform(-2,2) for the sake of being able to sample. If that is the case, I'm happy to write a PR to sample from (some of) these.

@junpenglao
Copy link
Member

Sample you mean random generation right? In that case you should pass a pm.Uniform.dist(-2, 2) to init

@kyleabeauchamp
Copy link
Contributor

Yeah, I think we need to add a note about this in the docstring. I spent over an hour tracking this down and assumed I had a botched theano installation...

@twiecki
Copy link
Member

twiecki commented Feb 7, 2019

@kyleabeauchamp Yes, a note is a good idea.

Note that you can sample (if the GaussianRandomWalk is an observed) by adding nans over the period you want to sample.

@ricardoV94
Copy link
Member

Closing this as #4388 seems to fix this issue.

See also #4337 for a general timeseries random issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants