Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3793 #3843

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Fix issue 3793 #3843

merged 4 commits into from
Mar 20, 2020

Conversation

rpgoldman
Copy link
Contributor

Give pm.Data objects model-relative names, using the same procedure as is used for random variables.

This is necessary to make pm.Data work properly when there are submodels.

@rpgoldman rpgoldman added the WIP label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3843 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3843   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         135      135           
  Lines       21152    21159    +7     
=======================================
+ Hits        19194    19201    +7     
  Misses       1958     1958           
Impacted Files Coverage Δ
pymc3/data.py 79.88% <100.00%> (+0.11%) ⬆️
pymc3/tests/test_data_container.py 100.00% <100.00%> (ø)

Use Model.name_for() to relativize pm.Data names.
@rpgoldman
Copy link
Contributor Author

OK, this is good to go. Will someone please review and merge?

@rpgoldman rpgoldman removed the WIP label Mar 19, 2020
@rpgoldman rpgoldman changed the title WIP: Fix issue 3793 Fix issue 3793 Mar 19, 2020
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelosthege
Copy link
Member

@twiecki I updated the release notes.. merge?

@twiecki twiecki merged commit 29821a5 into pymc-devs:master Mar 20, 2020
@twiecki
Copy link
Member

twiecki commented Mar 20, 2020

Thanks!

@rpgoldman rpgoldman deleted the iss3793 branch March 20, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants