Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention and test inputs can be > 1D in hessian_vector_prod #903

Open
ricardoV94 opened this issue Jul 8, 2024 · 0 comments
Open

Mention and test inputs can be > 1D in hessian_vector_prod #903

ricardoV94 opened this issue Jul 8, 2024 · 0 comments
Labels
beginner friendly docs tests

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Jul 8, 2024 •
edited
Loading

I don't think there is any reason to require wrt and p to be 1d. As long as wrt and p have the same shape(s) everything should be fine.

Maybe we can add a test for that and remove the "1-dimensional" from the docs?

Originally posted by @aseyboldt in #858 (review)
@ricardoV94 ricardoV94 added beginner friendly enhancement New feature or request labels Jul 8, 2024
@ricardoV94 ricardoV94 changed the title Allow >1d in hessian_vector_prod Mention inputs need not be 1D in hessian_vector_prod and test Jul 8, 2024
@ricardoV94 ricardoV94 changed the title Mention inputs need not be 1D in hessian_vector_prod and test Mention and test inputs can be > 1D in hessian_vector_prod Jul 8, 2024
@ricardoV94 ricardoV94 added docs tests and removed enhancement New feature or request labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly docs tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricardoV94