Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use contraction path to optimize pt.nlinalg.matrix_dot #961

Open
jessegrabowski opened this issue Aug 5, 2024 · 0 comments
Open

Use contraction path to optimize pt.nlinalg.matrix_dot #961

jessegrabowski opened this issue Aug 5, 2024 · 0 comments
Labels
enhancement New feature or request feature request linalg Linear algebra NumPy compatibility

Comments

@jessegrabowski
Copy link
Member

jessegrabowski commented Aug 5, 2024 •
edited
Loading

Description

Right now we have a function pt.nlinalg.matrix_dot that is just a helper for doing repeated dot products. This is similar to but worse than np.linalg.multi_dot, because multi_dot also computes an optimal contraction path, and does the dot products in a smart order.

#722 added optimized contraction path logic, so we could include this into our matrix_dot function. While we're at it, we should rename the function to multi_dot to match the numpy API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request linalg Linear algebra NumPy compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessegrabowski