Dimshuffle does not need input broadcastable info #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
0a667f6
to
278faf6
Compare
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
5 times, most recently
from
0556779
to
57ff2b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 81.72% 81.73%
=======================================
Files 182 182
Lines 47598 47584 -14
Branches 11589 11579 -10
=======================================
- Hits 38901 38891 -10
+ Misses 6508 6506 -2
+ Partials 2189 2187 -2
|
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
d573dd3
to
bf9f33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make DimShuffle less concerned about it's input static broadcastable type when dropping dims, since no behavior depends on it being specified at runtime.
But there is no reason the input broadcastable type had to be known in advance, since no behavior of the Op changes with that information. It's true that dropping it only works when the runtime shape is of length 1, but that will naturally fail when we try to do it for different shape lengths.
Alternatively / in addition we could plaster
specify_broadcastableduring make_node. Beyond this potential extension, I see no reason why DimShuffle should be so strict.This fixes the bug reported in #969
Related Issue