Cleanup Max and Argmax #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
approved these changes
Jul 8, 2024
| out = makeKeepDims(a, out, axis) | ||
| argout = makeKeepDims(a, argout, axis) | ||
| return [out, argout] | ||
| return [ |
There was a problem hiding this comment.
Do we still need max_and_argmax? I thought the original reason for it was because the two operations were originally fused somehow, so when you asked for one you got the other one "for free". Seems like they are fully separate now.
There was a problem hiding this comment.
They are, now the function is just a backwards compat tiny wrapper
pytensor/tensor/elemwise.py
Outdated
| @@ -1220,6 +1220,20 @@ class CAReduce(COp): | |||
|
|
|||
| __props__ = ("scalar_op", "axis", "dtype", "acc_dtype", "upcast_discrete_output") | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
This looks more like a staticmethod
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
=======================================
Coverage 81.23% 81.24%
=======================================
Files 170 170
Lines 47008 46920 -88
Branches 11516 11482 -34
=======================================
- Hits 38187 38120 -67
+ Misses 6612 6600 -12
+ Partials 2209 2200 -9
|
ricardoV94
force-pushed
the
cleanup_max_argmax
branch
3 times, most recently
from
d1b0d8a
to
0f87a69
Compare
ricardoV94
force-pushed
the
cleanup_max_argmax
branch
from
0f87a69
to
6cb0302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spinoff from #888 and follow up to #731
Related Issue
Checklist
Type of change