Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle error message changed #966

Merged
merged 7 commits into from
Aug 10, 2024
Merged

Pickle error message changed #966

merged 7 commits into from
Aug 10, 2024

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Aug 9, 2024

CI is failing.

@twiecki
Copy link
Member Author

twiecki commented Aug 9, 2024

pre-commit.ci autofix

@twiecki
Copy link
Member Author

twiecki commented Aug 9, 2024

Ugh, seems like the strings are slightly different for python 3.11 and 3.12.

tests/test_config.py Outdated Show resolved Hide resolved
@twiecki
Copy link
Member Author

twiecki commented Aug 10, 2024

pre-commit.ci autofix

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (0ae3cfe) to head (a28b55c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         182      182           
  Lines       47585    47585           
  Branches    11584    11584           
=======================================
  Hits        38875    38875           
- Misses       6518     6520    +2     
+ Partials     2192     2190    -2     

see 2 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 7fffec6 into main Aug 10, 2024
59 checks passed
@ricardoV94 ricardoV94 deleted the fix_pickle_test branch August 10, 2024 10:53
Ch0ronomato pushed a commit to Ch0ronomato/pytensor that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants