Text alignment is broken for redact annotations (>=1.18.17)

[caerulescens]

Describe the bug (mandatory)

The align argument does not work as it should. Text within the textbox is always aligned left.

To Reproduce (mandatory)

• Install PyMuPDF>=1.18.17
• Run below

import fitz

doc = fitz.Document()
doc.new_page()
page = doc[0]
x0, y0 = (100, 100)
x1, y1 = (250, 150)
rect = fitz.Rect(x0, y0, x1, y1)
page.add_redact_annot(rect,
                      text='text',
                      fontname="helv",
                      fontsize=12,
                      align=1,
                      text_color=(1, 1, 1),
                      fill=(0, 0, 0))
page.apply_redactions()
doc.save('./out.pdf')

Expected behavior (optional):

See here. In the code above, since align=1, the text should be centered in the redact annotation.

Screenshots (optional)

Actual:

Expected:

Your configuration (mandatory)

• Operating system: debian 10
• Python version: 3.9.1
• PyMuPDF version: 1.18.16 is the most recent release without this issue; I confirmed the issue for 1.18.17, 1.18.18, and 1.18.19.

[JorjMcKie]

Accepted - typo.
Will be corrected in next version.

[caerulescens]

Thanks

[caerulescens]

@JorjMcKie This is fixed for align=0, 1, 2 in 1.19.0. Using the same script, see screenshots below.

align = 0, expected left ✔️

align = 1, expected center ✔️

align = 2, expected right ✔️

[caerulescens]

align=3 is working correctly too!

align = 0, expected left ✔️

align = 3, expected justified ✔️

[JorjMcKie]

Thank you very much for testing and confirming all this so thoroughly!

[caerulescens]

Interesting, it seems the periods at the end of "words" weren't considered during the justification. Is that expected? If you use a textbox instead of a redact annotation and draw a rectangle with outline, you can see it. See screenshot below.

align=3

Also, should the text be vertically centered, similar to the redact annotation? I'm guessing no.

[JorjMcKie]

Also, should the text be vertically centered, similar to the redact annotation? I'm guessing no.

No. I am actually using a an unpleasent code to achieve something close to vertical centering in redact annots. It always is just an approximation there.

Strictly speaking, align=3 is not supported by PDF, only values 0, 1, 2 are:

So my internal spec /Q 3 is illegal anyway and may be ignored or otherwise handled in an unexpected way by other software.
I think I will remove this value and restrict to the official range.

Interesting though what happened to the dots - maybe internally changed to the Python Ellipsis. I will look into it.

[JorjMcKie]

Justified alignment has an error in insert_textbox, I can reproduce it independent from redactions.
So that must be fixed no matter what.

[JorjMcKie]

Justified alignment has an error in insert_textbox, I can reproduce it independent from redactions. So that must be fixed no matter what.

Found and fixed that error. As I said, this was caused by an error in insert_textbox() directly:
To support justification, I compute the word lengths within a line and then adjust the length of the spaces in that same line such that the sum of all lengths equal line length.
This PDF parameter, called Tw ("set word spacing") must be explicitely set to 0 for the last line (which must not be justified ever). This did not happen. No idea why this was undetected until today.
So instead of this:

one should now see this:

[JorjMcKie]

Resolved in new version 1.19.0 which is currently being uploaded.

[cajmorgan]

Hello! This bug is re-introduced in the newer version