Support for additionalProperties

[mjgolinski]

According to OAI/OpenAPI-Specification#38 (comment) swagger 2.0 supports additionalProperties. However i searched the codebase for string 'additionalProperties' and didn't find anything, hence my doubts.

[mjgolinski]

I checked it myself - it isn't supported. For us it's a showstopper because we have lots of maps in our API

[mission-liao]

Interesting, I didn't see that property shown in the spec of Swagger 2.0. Let's me check how it works.

[mission-liao]

Just found I asked similar question in Google Groups....

I tend to provide a partial support on additionalProperties for your case.

The problem is, this property contains 2 different types of value: a boolean or a Schema object.
To support what you need, I just need to support additionalProperties with a Schema object, which is easier.

The boolean case would be resolved later but not now, is that OK?
You could check the progress in this branch https://github.com/mission-liao/pyswagger/tree/addp

[mission-liao]

Here is the testing case I would use in this case, let me know if this is not what you expected.

{
   "swagger":"2.0",
   "host":"http://test.com",
   "basePath":"/v1",
   "paths":{

   },
   "definitions":{
      "Category":{
         "properties":{
            "id":{
               "type":"integer",
               "format":"int64"
            },
            "name":{
               "type":"string"
            }
         }
      },
      "add_prop":{
         "properties":{
            "name_of_map":{
               "type":"string"
            }
         },
         "additionalProperties":{
            "$ref":"#/definitions/Category"
         }
      }
   }
}

[mjgolinski]

Just to confirm, following JSON should fit your schema:

{
    "name_of_map": "my map",
    "prop1": {
        "id": 1,
        "name": "property 1"
    },
    "prop2": {
        "id": 2,
        "name": "property no. 2"
    },
}

If so, it's exactly what I need.
BTW could I also define additionalProperties inline (as opposed to using $ref)?

[mission-liao]

Sure, it will works when inlined.

[mission-liao]

Just create a PR, will be merged once we finished your PR.

[mission-liao]

Just merge to master, will give a new build once Json_Reference is done.

[mission-liao]

Just update a new build on pypi, you could verify this issue with new build.

For adding support on type:'number' or 'integer' without format, I gonna provide some way for users to register their own primitive handlers.