Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is monkeypatch_for_cert needed any more? #136

Open
pfmoore opened this issue Dec 28, 2021 · 4 comments
Open

Is monkeypatch_for_cert needed any more? #136

pfmoore opened this issue Dec 28, 2021 · 4 comments

Comments

@pfmoore
Copy link
Member

pfmoore commented Dec 28, 2021

Nowadays, pip extracts the cert bundle from certifi to a temporary file (see #pip/10753). As far as I can see, monkeypatch_for_cert here does basically the same thing.

Could we just remove that function?

@pradyunsg
Copy link
Member

I think so. Someone can try this out, and ensure that it is indeed the case.

@pfmoore
Copy link
Member Author

pfmoore commented Jan 6, 2022

I might have a go at that if & when I can work out how I'd test such a change... But if anyone else gets to it first, I won't object 🙂

@pradyunsg
Copy link
Member

pradyunsg commented Jan 6, 2022

FWIW, how to work on this repository for iterating on things like this:

  • Update the templates.
  • nox -s generate (regenerates the get-pip.py files)
  • nox -s check-3.9 (runs the relevant script in a clean venv)

@pradyunsg
Copy link
Member

I think things should blow up -- certifi should fail, IIUC -- if removing the whole monkeypatching thing isn't something the code can handle. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants